Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure PostgreSQL field length change is executed again #6490

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Ensure PostgreSQL field length change is executed again #6490

merged 1 commit into from
Aug 13, 2024

Conversation

sbuerk
Copy link
Contributor

@sbuerk sbuerk commented Aug 13, 2024

With #6280 quite some changes has been applied,
which removed the code path to create alter sql
statement if length of a field has changed.

This change adds a general test for this case
and reimplement the accidently removed code
from the PostgreSQLPlatform.

@sbuerk sbuerk force-pushed the stefan-1 branch 2 times, most recently from af7e961 to 0a50d68 Compare August 13, 2024 16:58
@sbuerk
Ensure PostgreSQL field length change is executed again
55af948 
With doctrine#6280 quite some changes has been applied,
which removed the code path to create alter sql
statement if length of a field has changed.

This change adds a general test for this case
and reimplement the accidently removed code
from the `PostgreSQLPlatform`.
@greg0ire greg0ire added the Bug label Aug 13, 2024
@derrabus derrabus merged commit 741e9fc into doctrine:4.1.x Aug 13, 2024
78 of 79 checks passed
@derrabus derrabus added this to the 4.1.0 milestone Aug 13, 2024
@sbuerk sbuerk deleted the stefan-1 branch August 13, 2024 19:09
derrabus added a commit that referenced this pull request Aug 14, 2024
@derrabus
Merge branch '4.1.x' into 5.0.x
00837c0 
* 4.1.x:
  Add deprecation layer for TableDiff methods (#6482)
  Ensure PostgreSQL field length change is executed again (#6490)
reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this pull request Aug 15, 2024
@sbuerk
[TASK] Raise doctrine/dbal:^4.1
72b3729 
The Doctrine Team recently released minor version
release `4.1.0` including a couple of bugfixes,
internal changes and also new features [1].

The aforementioned internal changes introduces
breaking stuff within internal implementation,
for example the TYPO3 Database Analyzer stack
enforcing adoption [2][3][4]. Sadly, it's not
possible to provide backwards compatible code
and thus minimum version raise is "absolutly"
required.

Doctrine DBAL 4.1.0 also includes new platform
implementation for some database platforms and
this change adds them as extend replacements
to ensure working state with TYPO3 DB Analyzer.

Note that previous TYPO3 v13.x composer instances
needs to limit doctrine/dbal to 4.0.x on their own
to avoid breaking behaviour.

Used command(s):

\
  composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^4.1" \
  && composer require "doctrine/dbal":"^4.1"

[1] https://github.com/doctrine/dbal/releases/tag/4.1.0
[2] doctrine/dbal#6280
[3] doctrine/dbal#6482
[4] doctrine/dbal#6490

Resolves: #104628
Releases: main
Change-Id: I53c86feed17abc6a90625e27fb135f606a57fc9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85620
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam pushed a commit to TYPO3-CMS/core that referenced this pull request Aug 15, 2024
@sbuerk
[TASK] Raise doctrine/dbal:^4.1
3e942de 
The Doctrine Team recently released minor version
release `4.1.0` including a couple of bugfixes,
internal changes and also new features [1].

The aforementioned internal changes introduces
breaking stuff within internal implementation,
for example the TYPO3 Database Analyzer stack
enforcing adoption [2][3][4]. Sadly, it's not
possible to provide backwards compatible code
and thus minimum version raise is "absolutly"
required.

Doctrine DBAL 4.1.0 also includes new platform
implementation for some database platforms and
this change adds them as extend replacements
to ensure working state with TYPO3 DB Analyzer.

Note that previous TYPO3 v13.x composer instances
needs to limit doctrine/dbal to 4.0.x on their own
to avoid breaking behaviour.

Used command(s):

\
  composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^4.1" \
  && composer require "doctrine/dbal":"^4.1"

[1] https://github.com/doctrine/dbal/releases/tag/4.1.0
[2] doctrine/dbal#6280
[3] doctrine/dbal#6482
[4] doctrine/dbal#6490

Resolves: #104628
Releases: main
Change-Id: I53c86feed17abc6a90625e27fb135f606a57fc9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85620
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam pushed a commit to TYPO3-CMS/install that referenced this pull request Aug 15, 2024
@sbuerk
[TASK] Raise doctrine/dbal:^4.1
968e6cb 
The Doctrine Team recently released minor version
release `4.1.0` including a couple of bugfixes,
internal changes and also new features [1].

The aforementioned internal changes introduces
breaking stuff within internal implementation,
for example the TYPO3 Database Analyzer stack
enforcing adoption [2][3][4]. Sadly, it's not
possible to provide backwards compatible code
and thus minimum version raise is "absolutly"
required.

Doctrine DBAL 4.1.0 also includes new platform
implementation for some database platforms and
this change adds them as extend replacements
to ensure working state with TYPO3 DB Analyzer.

Note that previous TYPO3 v13.x composer instances
needs to limit doctrine/dbal to 4.0.x on their own
to avoid breaking behaviour.

Used command(s):

\
  composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^4.1" \
  && composer require "doctrine/dbal":"^4.1"

[1] https://github.com/doctrine/dbal/releases/tag/4.1.0
[2] doctrine/dbal#6280
[3] doctrine/dbal#6482
[4] doctrine/dbal#6490

Resolves: #104628
Releases: main
Change-Id: I53c86feed17abc6a90625e27fb135f606a57fc9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85620
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
TYPO3IncTeam pushed a commit to TYPO3-CMS/redirects that referenced this pull request Aug 15, 2024
@sbuerk
[TASK] Raise doctrine/dbal:^4.1
bc5c65e 
The Doctrine Team recently released minor version
release `4.1.0` including a couple of bugfixes,
internal changes and also new features [1].

The aforementioned internal changes introduces
breaking stuff within internal implementation,
for example the TYPO3 Database Analyzer stack
enforcing adoption [2][3][4]. Sadly, it's not
possible to provide backwards compatible code
and thus minimum version raise is "absolutly"
required.

Doctrine DBAL 4.1.0 also includes new platform
implementation for some database platforms and
this change adds them as extend replacements
to ensure working state with TYPO3 DB Analyzer.

Note that previous TYPO3 v13.x composer instances
needs to limit doctrine/dbal to 4.0.x on their own
to avoid breaking behaviour.

Used command(s):

\
  composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^4.1" \
  && composer require "doctrine/dbal":"^4.1"

[1] https://github.com/doctrine/dbal/releases/tag/4.1.0
[2] doctrine/dbal#6280
[3] doctrine/dbal#6482
[4] doctrine/dbal#6490

Resolves: #104628
Releases: main
Change-Id: I53c86feed17abc6a90625e27fb135f606a57fc9f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85620
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
Bug PostgreSQL Schema Comparison
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sbuerk @greg0ire @derrabus